Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src, permission: make ERR_ACCESS_DENIED more descriptive #57585

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RafaelGSS
Copy link
Member

This commit also adds a suggestion flag (if exists) when ERR_ACCESS_DENIED is thrown, so users don't need to jump into the documentation to see how to manage that permission error.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 21, 2025

Review requested:

  • @nodejs/security-wg

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label Mar 21, 2025
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 21, 2025
@RafaelGSS RafaelGSS changed the title src: make ERR_ACCESS_DENIED more descriptive src, permission: make ERR_ACCESS_DENIED more descriptive Mar 21, 2025
This commit also adds a suggestion flag (if exists)
when ERR_ACCESS_DENIED is thrown, so users don't need
to jump into the documentation to see how to manage
that permission error.
@RafaelGSS RafaelGSS force-pushed the improve-error-message-permission-model branch from 802f91c to 3c14972 Compare March 21, 2025 19:05
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (9851388) to head (b42155d).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
src/permission/permission.cc 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57585      +/-   ##
==========================================
- Coverage   90.23%   90.23%   -0.01%     
==========================================
  Files         629      630       +1     
  Lines      184947   185136     +189     
  Branches    36229    36237       +8     
==========================================
+ Hits       166882   167052     +170     
- Misses      11017    11047      +30     
+ Partials     7048     7037      -11     
Files with missing lines Coverage Δ
src/permission/permission.cc 78.49% <75.00%> (-0.58%) ⬇️

... and 60 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants