-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module: remove unnecessary readPackage
function
#57596
Open
dario-piotrowicz
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
dario-piotrowicz:dario/remove-readPackage-function
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
module: remove unnecessary readPackage
function
#57596
dario-piotrowicz
wants to merge
1
commit into
nodejs:main
from
dario-piotrowicz:dario/remove-readPackage-function
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
JakobJingleheimer
approved these changes
Mar 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57596 +/- ##
=======================================
Coverage 90.22% 90.22%
=======================================
Files 630 630
Lines 185149 185117 -32
Branches 36236 36242 +6
=======================================
- Hits 167058 167030 -28
- Misses 11035 11038 +3
+ Partials 7056 7049 -7
🚀 New features to boost your workflow:
|
aduh95
approved these changes
Mar 23, 2025
marco-ippolito
approved these changes
Mar 23, 2025
jsumners-nr
approved these changes
Mar 24, 2025
bjohansebas
approved these changes
Mar 24, 2025
jasnell
approved these changes
Mar 24, 2025
anonrig
approved these changes
Mar 24, 2025
RaisinTen
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
module
Issues and PRs related to the module subsystem.
needs-ci
PRs that need a full CI run.
request-ci
Add this label to start a Jenkins CI on a PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.