BUG: Added deprecation warning to Timestamp constructor #61149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Mar 29, 2025
pandas/tests/indexing/test_loc.py
Outdated
| @pytest.mark.filterwarnings("ignore:indexing past lexsort depth") | ||
| @pytest.mark.filterwarnings( | ||
| "ignore:indexing past lexsort depth", | ||
| "ignore:Passing an empty string to Timestamp", |
There was a problem hiding this comment.
Instead of ignoring in each of these tests, can you test the warning. See
https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#testing-a-warning
rhshadrach
added
Deprecate
…dricks/pandas into add-warning-timestamp-blank-string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11953
Added deprecation warning to Timestamp constructor when
ts_input = "".This addition was motivated by this comment: #11953 (comment)
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.