Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another Korean translation #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbyeol3
Copy link

@sbyeol3 sbyeol3 commented Jul 9, 2021

I found this repository and translated it to study for myself.
There's already a Korean translation, but it's a little different from mine.

I hope my contribution will be added. thanks :)

@jjangga0214
Copy link

jjangga0214 commented Jul 9, 2021

but it's a little different from mine.

I'd like ask some questions.

  • How much different?
  • Do you think yours is better?
  • Are there pros and cons between the two?
  • Why don't you just create a PR against the original translation?
  • Or do you think it's just better for people to let choose one over the other, by their personal preference?

P.S: I am also a native Korean as well. Consider describing the answer in Korean if you cannot, or feel really difficult to, explain a subtle difference in English. (But avoid it as much as possible for other people.)

@sbyeol3
Copy link
Author

sbyeol3 commented Jul 9, 2021

reply to @jjangga0214

The existing translation is really good, but when I read it, I think there are some parts that have been removed for natural translation. In some ways, more paraphrases were added to my translation to make it easier to explain.
If you are Korean, you will probably feel a little difference when you read it. 🤓
I think it depends on the reader which one is better.
-> answer to 1~3

When I started translating, I didn't know that there was already a Korean translation.
So when I read what has already been translated, I thought it would be a little difficult to send PR to the repo because the expression were slightly different. (Each translator has a slightly different style. 😇 )
-> answer to 4

In addition, some languages appear to have multiple translations.
So I sent PR to add one more, not to remove the existing Korean translation.
It means that it would be good for Korean developers to choose something that is easier to accept.
-> answer to 5

I haven't translated much, so I'm not good at it. Thanks for your advice. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants