Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new naming good practice #364

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Karan0009
Copy link

Use same type of casing style for same type of data in all the project

@Karan0009
Copy link
Author

kindly review this pr

Copy link

@thedivloop thedivloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to remove the good examples from the "bad" group to avoid confusion. For instance let anotherVariable = 0 is in both good and bad group. Same comment for AFunction.
Thanks

Copy link
Author

@Karan0009 Karan0009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 👍

@Karan0009 Karan0009 closed this Jul 4, 2023
@Karan0009 Karan0009 reopened this Jul 4, 2023
@Karan0009
Copy link
Author

Karan0009 commented Jul 4, 2023

Hey can you please merge this branch. After I make the required changes

@Karan0009
Copy link
Author

@thedivloop Kindly review the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants