-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix EditorConfig lint errors (issue #6213) #6215
Merged
kgryte
merged 3 commits into
stdlib-js:develop
from
AlyAbdelmoneim:fix/editorconfig-indentation
Mar 21, 2025
Merged
chore: fix EditorConfig lint errors (issue #6213) #6215
kgryte
merged 3 commits into
stdlib-js:develop
from
AlyAbdelmoneim:fix/editorconfig-indentation
Mar 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
The above coverage report was generated for the changes in this PR. |
aayush0325
previously approved these changes
Mar 21, 2025
a9a3871
to
104f77d
Compare
@aayush0325 Hello, thanks for the approval, it seems that I didn't have the signature correct on the commits so the merging was blocked, I fixed that, does it need another approval ? |
kgryte
reviewed
Mar 21, 2025
lib/node_modules/@stdlib/random/streams/betaprime/lib/defaults.json
Outdated
Show resolved
Hide resolved
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
@kgryte done ! |
kgryte
approved these changes
Mar 21, 2025
Girish-Garg
pushed a commit
to Girish-Garg/stdlib
that referenced
this pull request
Mar 23, 2025
PR-URL: stdlib-js#6215 Closes: stdlib-js#6213 Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6213.
Description
This pull request:
defaults.json
files by replacing tabs with spaces to comply with EditorConfig rules.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers