Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix EditorConfig lint errors (issue #6213) #6215

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

AlyAbdelmoneim
Copy link
Contributor

Resolves #6213.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes indentation issues in defaults.json files by replacing tabs with spaces to comply with EditorConfig rules.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 20, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 20, 2025

Coverage Report

Package Statements Branches Functions Lines
random/streams/betaprime 819 / 819
+ 100.00 %
95 / 95
+ 100.00 %
15 / 15
+ 100.00 %
819 / 819
+ 100.00 %
random/streams/discrete-uniform 826 / 826
+ 100.00 %
96 / 96
+ 100.00 %
15 / 15
+ 100.00 %
826 / 826
+ 100.00 %

The above coverage report was generated for the changes in this PR.

aayush0325
aayush0325 previously approved these changes Mar 21, 2025
@AlyAbdelmoneim AlyAbdelmoneim force-pushed the fix/editorconfig-indentation branch from a9a3871 to 104f77d Compare March 21, 2025 13:53
@AlyAbdelmoneim
Copy link
Contributor Author

@aayush0325 Hello, thanks for the approval, it seems that I didn't have the signature correct on the commits so the merging was blocked, I fixed that, does it need another approval ?

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 21, 2025
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@AlyAbdelmoneim
Copy link
Contributor Author

@kgryte done !

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 21, 2025
@kgryte kgryte merged commit 9ecb767 into stdlib-js:develop Mar 21, 2025
11 checks passed
@AlyAbdelmoneim AlyAbdelmoneim deleted the fix/editorconfig-indentation branch March 21, 2025 23:00
Girish-Garg pushed a commit to Girish-Garg/stdlib that referenced this pull request Mar 23, 2025
PR-URL: stdlib-js#6215
Closes: stdlib-js#6213
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Aayush Khanna <aayushiitbhu23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
4 participants