feat: add stats/incr/nanmminmax
#6422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
Statistics
Coverage Report
The above coverage report was generated for the changes in this PR. |
hrshya
reviewed
Mar 28, 2025
|
|
||
| # incrnanmminmax | ||
|
|
||
| > Compute a moving minimum and maximum incrementally ignoring `NaN` values. |
There was a problem hiding this comment.
Suggested change
| > Compute a moving minimum and maximum incrementally ignoring `NaN` values. | |
| > Compute a moving minimum and maximum incrementally, ignoring `NaN` values. |
|
|
||
| <section class="related"> | ||
|
|
||
| * * * |
|
|
||
| <section class="links"> | ||
|
|
||
| <!-- <related-links> --> |
| var i; | ||
| b.tic(); | ||
| for ( i = 0; i < b.iterations; i++ ) { | ||
| f = incrnanmminmax( (i%5)+1 ); |
There was a problem hiding this comment.
Suggested change
| f = incrnanmminmax( (i%5)+1 ); | |
| f = incrnanmminmax( ( i%5 ) + 1 ); |
| import { ArrayLike } from '@stdlib/types/array'; | ||
|
|
||
| /** | ||
| * If provided a value, the accumulator function returns updated minimum and maximum values. If not provided a value, the accumulator function returns the current minimum and maximum values. |
There was a problem hiding this comment.
There is repetitive code in this file so please fix it.
There was a problem hiding this comment.
I have noticed that as well and didn't understand that too but this repetitive code is also present in mminmax package as well.
| * @param {number} [x] - new value | ||
| * @returns {(ArrayLikeObject|null)} min/max array or null | ||
| */ | ||
| function accumulator(x) { |
There was a problem hiding this comment.
Suggested change
| function accumulator(x) { | |
| function accumulator( x ) { |
| * @returns {(ArrayLikeObject|null)} min/max array or null | ||
| */ | ||
| function accumulator(x) { | ||
| if (arguments.length === 0 || isnan(x)) { |
There was a problem hiding this comment.
Suggested change
| if (arguments.length === 0 || isnan(x)) { | |
| if ( arguments.length === 0 || isnan( x ) ) { |
| if (arguments.length === 0 || isnan(x)) { | ||
| return mminmax(); | ||
| } | ||
| return mminmax(x); |
There was a problem hiding this comment.
Suggested change
| return mminmax(x); | |
| return mminmax( x ); |
| { | ||
| "name": "@stdlib/stats/incr/nanmminmax", | ||
| "version": "0.0.0", | ||
| "description": "Compute a moving minimum and maximum incrementally.", |
There was a problem hiding this comment.
Suggested change
| "description": "Compute a moving minimum and maximum incrementally.", | |
| "description": "Compute a moving minimum and maximum incrementally, ignoring `NaN` values.", |
| ]; | ||
|
|
||
| for ( i = 0; i < values.length; i++ ) { | ||
| t.throws( badValue( values[i] ), TypeError, 'throws an error when provided '+values[i] ); |
There was a problem hiding this comment.
Suggested change
| t.throws( badValue( values[i] ), TypeError, 'throws an error when provided '+values[i] ); | |
| t.throws( badValue( values[ i ] ), TypeError, 'throws an error when provided '+values[ i ] ); |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5596
Description
This pull request:
Related Issues
This pull request:
stats/incr/nanmminmax#5596Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers