Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix phpclass reference with namespaces #20822

Open
wants to merge 1 commit into
base: 7.3
Choose a base branch
from
Open

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 25, 2025

The link is currently broken (see https://symfony.com/doc/7.3/serializer.html).

@carsonbot carsonbot added this to the 7.3 milestone Mar 25, 2025
@@ -1388,12 +1388,12 @@ normalizers (in order of priority):
want ``null`` instead, you can set the ``BackedEnumNormalizer::ALLOW_INVALID_VALUES`` option.

:class:`Symfony\\Component\\Serializer\\Normalizer\\NumberNormalizer`
This normalizer converts between :phpclass:`BcMath\\Number` or :phpclass:`GMP` objects and
This normalizer converts between :phpclass:`BcMath\Number` or :phpclass:`GMP` objects and
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OskarStark Does doctor-rst require an update to also handle symfony-tools/docs-builder#190?

Copy link
Contributor

@OskarStark OskarStark Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why class requires double slash, but phpclass doesn't. Don't they use the exact same rst feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants