mcslock: refine builtins to c11 atomic #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Aug 30, 2023
jserv
reviewed
Aug 30, 2023
mcslock/tests.c
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| int main(void) | |||
| { | |||
| mcslock_t lock; | |||
| _Atomic(mcslock_t) lock; | |||
There was a problem hiding this comment.
It is a bit inconvenient. Users may regard mcslock_t as the userspace implementation of MCS lock and use mcslock_t without _Atomic.
There was a problem hiding this comment.
Yes, that's inconvenient, and I moved definition of _Atomic for lock from test.c to msclock.h. Currently, users can use mcslock_t without _Atomic.
|
Thank @zondatw for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.