Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Days 09-12 Building APIs with Api Star (0.5.x) #15

Closed
alex-vegan opened this issue Jul 17, 2019 · 1 comment
Closed

Days 09-12 Building APIs with Api Star (0.5.x) #15

alex-vegan opened this issue Jul 17, 2019 · 1 comment

Comments

@alex-vegan
Copy link

009-012-modern-apis-starred/demo/app.py
for function create_car() we define car_id like len(cars)+1 but after first delete_car() it dosn't work!
isn't better to check max(cars.keys())+1 for same task, or something else?
bbelderbos added a commit that referenced this issue Jul 18, 2019
@bbelderbos
fix for
6262742 
#15
@bbelderbos
Copy link
Collaborator

Hey @alex-vegan this indeed failed! 6262742 - added a test and implemented your fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbelderbos @alex-vegan