Skip to content

Days 65-68 Heroku - Sendgrid changes #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shutteritch opened this issue Jun 4, 2020 · 5 comments
Closed

Days 65-68 Heroku - Sendgrid changes #36

shutteritch opened this issue Jun 4, 2020 · 5 comments
Assignees

Comments

@shutteritch
Copy link
Contributor

Hello!

I had two errors when trying to send email with sendgrid.

The first seemed to relate to the order of the variables in which I had to change from:
mail = Mail(from_email, subject, to_email, content)
to:
mail = Mail(from_email, to_email, subject, content)

And then the second referred to the response which I had to change from:
response = sg.client.mail.send.post(request_body=mail.get())
to:
response = sg.send(mail)

I also discovered that I didn't need to import Email & Content so the following worked for me:

import sendgrid
from sendgrid.helpers.mail import Mail

sg = sendgrid.SendGridAPIClient(api_key="MY_API_KEY")

from_email = "test@example.com"
subject = "Winter is coming"
to_email = "myemail@gmail.com"
content = "Hey Iain, This works much better"

mail = Mail(from_email, to_email, subject, content)

response = sg.send(mail)

print(response.status_code)
print(response.body)
print(response.headers)

@shutteritch
Copy link
Contributor Author

@bbelderbos bbelderbos self-assigned this Jun 4, 2020
@bbelderbos
Copy link
Collaborator

Thanks @shutteritch I will look tomorrow.

@bbelderbos
Copy link
Collaborator

Ah seems @hobojoe1848's lesson actually. I see he pinned it to sendgrid==5.6.0, are you using that version or 6.x?

We upgraded back in December on the platform and struggled with some breaking changes in 6.1.0.

Looking at our changes then:

-sendgrid==5.6.0
+sendgrid==6.1.0
...
-sg = sendgrid.SendGridAPIClient(apikey=config('SENDGRID_API_KEY'))
+sg = sendgrid.SendGridAPIClient(api_key=config('SENDGRID_API_KEY'))
...
-    mail = Mail(from_email, subject, to_email, content)
+    mail = Mail(from_email, to_email, subject, content)
...
+    message = Mail(
+        from_email=from_email,
+        to_emails=to_email,
+        subject=subject,
+        plain_text_content=body if not html else None,
+        html_content=body if html else None
+    )
...
+    response = sg.send(message) 
(before)
sg.client.mail.send.post(request_body=mail.get())

So yeah I think it would be useful to include a script for sendgrid 6.x as that is the default now.

@bbelderbos
Copy link
Collaborator

@shutteritch we can include one, but as you seem to have one ready, you could also contribute by opening a PR against this repo. Thanks

@bbelderbos
Copy link
Collaborator

Seems this was fixed via PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants