Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change day 9-12 requirements.txt and readme.md Day3 instruction to apistar==0.5.41 for package 0.6+ breaking changes #6

Merged
merged 3 commits into from
May 9, 2019

Conversation

ericchou1
Copy link
Contributor

Raised a potential issue #5 for apistar package changes from 0.5.41 to 0.6+ that did away with servers (http://docs.apistar.com/). Not sure if my interpretation is correct, at least 0.7.2 did not work on my setup while 0.5.41 works, submitting PR in case this was indeed the case.

@ericchou1 ericchou1 changed the title change day 9-12 requirements.txt: apistar==0.5.41 for 6+ breaking changes change day 9-12 requirements.txt: apistar==0.5.41 for 0.6+ breaking changes May 9, 2019
@ericchou1 ericchou1 changed the title change day 9-12 requirements.txt: apistar==0.5.41 for 0.6+ breaking changes change day 9-12 requirements.txt and readme.md Day3 instruction to apistar==0.5.41 for package 0.6+ breaking changes May 9, 2019
@mikeckennedy mikeckennedy merged commit 804b91e into talkpython:master May 9, 2019
@bbelderbos
Copy link
Collaborator

bbelderbos commented May 10, 2019

requirements.txt had the fix but forgot to document it in the README so thanks for that change @ericchou1, and for merging it in @mikeckennedy. I am adding a callout in the video where I pip install apistar as well.

@mikeckennedy
Copy link
Member

Thanks Bob. I just published the updated videos. Will take up to 5 min to replicate to your region. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants