-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add ability to configure IPAM exclusively for IPv4 or IPv6 #1155
base: master
Are you sure you want to change the base?
feat!: Add ability to configure IPAM exclusively for IPv4 or IPv6 #1155
Conversation
The changes are satisfactory to me |
you need to use |
As far as I understand, when |
We might need IPAM only for IPv6 and not for IPv4. Enabling IPAM for IPv4 will monitor all the private IPs it manages, which adds more cost. Ex:
|
This PR has been automatically marked as stale because it has been open 30 days |
Description
PR delivers features to configure IPAM exclusively for IPv4 or IPv6 - previously it was 1 variable used for both IP protocols, so IPAM could be used for both or neither.
Motivation and Context
#1153
Breaking Changes
Previously it was defined 1 variable
use_ipam_pool
used for both IP protocol. In order to distinguish to which protocol IPAM should be used, there were introduced 2 new variablesuse_ipv4_ipam_pool
anduse_ipv6_ipam_pool
(old variableuse_ipam_pool
was removed).How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request