Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 表单在compact 压缩模式下, 错误提示与输入框重叠 #5633

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: 表单在compact 压缩模式下, 错误提示与输入框重叠 #5633

wants to merge 1 commit into from

Conversation

skyling
Copy link

@skyling skyling commented Mar 2, 2025 •
edited by coderabbitai bot
Loading

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Refactor
    • Enhanced the display behavior for form feedback messages. Their positioning now adapts automatically based on the form’s compact setting, ensuring a consistent and responsive layout that improves visual clarity and user experience.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2025

⚠️ No Changeset found

Latest commit: cbccabc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2025 •
edited
Loading

Walkthrough

The pull request modifies the rendering of the FormMessage component within the form-field.vue file. The change replaces a fixed class (absolute bottom-1) with a dynamic class binding that always applies bottom-1 and conditionally applies absolute based on the compact property. This update adjusts the layout behavior of the component without altering any exported or public entities.

Changes

File Path Change Summary
packages/@core/ui-kit/form-ui/src/.../form-field.vue Updated FormMessage component in the template to use a dynamic class binding, applying absolute conditionally based on the compact property, while retaining bottom-1.

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • anncwb
  • vince292007

Poem

I'm a little rabbit with code so neat,
Hopping through classes with a rhythmic beat.
The absolute surprise now hides in plain view,
Conditional magic making the layout anew.
With every small change, our UI lights the street!
🐇 Hop on to merge, my dear coding friend!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e815f0f and cbccabc.

📒 Files selected for processing (1)
  • packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: post-update (windows-latest)
  • GitHub Check: post-update (ubuntu-latest)
🔇 Additional comments (1)
packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (1)

361-361: Good fix for the overlapping error message issue!

The change correctly addresses the problem where error messages overlap with input fields in compact mode. By making the absolute positioning conditional on the !compact state, error messages will follow normal document flow when in compact mode, preventing the overlap with input fields.

The original positioning was causing the error message to be positioned absolutely (detached from normal document flow) even in compact mode, which led to the visual bug.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mynetfan
Copy link
Collaborator

mynetfan commented Mar 3, 2025

其实一开始这个compact是为用于表格搜索之类的无校验的场景准备的。
如果校验信息不使用absolute布局，会在出现校验信息时破坏表单的整体布局

@skyling
Copy link
Author

skyling commented Mar 3, 2025

正常情况下:
image
absolute 布局下:
image
相对布局下:
image

相对布局下确实错误信息出现和消失时会有一个高度伸缩的问题. 相对于重合可能会稍微好一些吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anncwb anncwb

@vince292007 vince292007

@mynetfan mynetfan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyling @mynetfan