-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<transition-group> and v-show triggers move transition on enter #7879
Comments
Woohoo! I managed to break something! |
Can I give this issue a try? |
@vctt94 Of cause, welcome 😃 |
this coordinate is using getBoundingClientRect method to get value. How about change of line 8424 of vue.js The value can be taken |
hey @wlkuro, I believe you are right, and that is the cause. But we are not supposed to make changes on dist files. It is a self generated file, but the change you suggested does work. |
I see, what exactly this _enterCb does? |
I was playing around with an example from the docs and hit the same issue as described (e.g. toggle button: https://codepen.io/pen/BGjJGL). Since the PR is still open - are there currently any workarounds for this? Using |
Version
2.5.16
Reproduction link
https://jsfiddle.net/chrisvfritz/845Lee66/
Steps to reproduce
move
transition trigger on enterWhat is expected?
Just like with
v-if
, move transitions should not be triggered on enter (note that it is already not triggered on leave).What is actually happening?
I haven't checked in the source yet, but I'm guessing that since elements with
display: none
still technically have coordinates:The
move
transition is triggered on enter. I'm not sure why it wouldn't also occur on leave though.This may be connected to #5800. Also, special thanks to @rachelnabors for finding this bug!
The text was updated successfully, but these errors were encountered: