Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish: improve robustness of inject option #10154

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

liximomo
Copy link
Member

When a user provides a none-string object in inject array, it may fail at runtime because we try to make an implicit string conversion for the object in "Injection not found" warn. Objects like Symbol will fail at runtime because of such implicit conversion.

image

See the reproduction.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants