Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#11040): Add a warning when binding to object with empty keys #11523

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

CallumChaney
Copy link

@CallumChaney CallumChaney commented Jul 17, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
With this PR binding to an object with an empty key value will still cause Vue to crash just adds a clearer warning message as to why. The warning message could probably be even clearer.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but this should be done only when using v-bind="{'': 'foo'}, not directly in the observer code. A test is also needed

@CallumChaney
Copy link
Author

CallumChaney commented Jul 18, 2020

@posva ahh ok, sorry I'm still pretty new to Vue code base, could you point me towards the best place to make the change then I'm thinking the bind-object-props render-helper? I was also thinking that exiting baseSetAtrritube if the empty key is detected would prevent the crash, just want to make sure I'm tackling this bug right. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants