Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid copying array if not necessary #11565

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

perf: avoid copying array if not necessary #11565

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9aa9707
Do not copy array if not necessary
Y-- Aug 4, 2020
9095384
style: Apply suggestions from code review
posva Sep 21, 2020
861499e
Merge branch 'vuejs:dev' into dev
Y-- Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/core/observer/dep.js
View file
Original file line number Diff line number Diff line change
@@ -36,8 +36,9 @@ export default class Dep {

notify () {
// stabilize the subscriber list first
const subs = this.subs.slice()
let subs = this.subs
if (process.env.NODE_ENV !== 'production' && !config.async) {
subs = this.subs.slice()
// subs aren't sorted in scheduler if not running async
// we need to sort them now to make sure they fire in correct
// order