fix: iframe-window-name-update #11578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ames window must be updated aswell. Otherwise anchor tags with a 'target' attribute won't hit the right iframe.
posva
reviewed
Mar 24, 2021
…frame element, the iframes window must be updated as well. Otherwise anchor tags with a 'target' attribute won't hit the right iframe.
posva
changed the title
krishan
reviewed
Jul 13, 2021
| // anchor tags with a 'target' attribute won't hit the right iframe. | ||
| if (el.tagName === 'IFRAME' && key === 'name' && el.contentWindow) { | ||
| // $flow-disable-line | ||
| el.contentWindow.name = value; |
There was a problem hiding this comment.
I could be wrong, but AFAICS this could trigger a browser security error, if the iFrame is cross-origin, e.g. like this:
Uncaught DOMException: Blocked a frame with origin "http://localhost:8080" from accessing a cross-origin frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: When changing the attribute 'name' of an iframe element, the iframes window must be updated aswell. Otherwise anchor tags with a 'target' attribute won't hit the right iframe.
Close #11569
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This Issue actually wasn’t only present in safari. When iframes are created a window will be attached to the iframe which actually is the target. When updating the name attribute of an existing iframe the window inside the iframe doesn’t get updated.
In native javascript you could fix this with:
document.querySelector('iframe').documentWindow.name = 'theNewName';
The reproduction fiddle in the Issue #11569 only is bugged in safari, but if you try to change the attribute dynamically it doesn’t work in chrome or firefox either.
Check this fiddle for the cross-platform issue : https://jsfiddle.net/ug2jhmL6/1/