fix(dev): allow performance marking in production (fix #11775) #11776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close vuejs#11775 Similar to devtools, `Vue.config.devtools` is enabled by default for development and disabled by default for production. However, the developer can choose to override that behavior (for example, for debugging) by manually setting `Vue.config.devtools = true`. However, this same lenience is not afforded to `Vue.config.performance`. Even if explicitly enabling it, the developer's setting will be overridden by Vue in production. This commit brings `Vue.config.performance` in line with `Vue.config.devtools`, by disabling it by default in production, but gives the developer the ability to explicitly enable it; for example, for debugging performance issues.
vegerot
force-pushed
the
production_performance
branch
from
522e50f to
f99f21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11775
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
To quote #11775 :
What problem does this feature solve?
Similar to devtools,
Vue.config.devtoolsis enabled by default for development and disabled by default for production. However, the developer can choose to override that behavior (for example, for debugging) by manually settingVue.config.devtools = true. However, this same lenience is not afforded toVue.config.performance. Even if explicitly enabling it, the developer's setting will be overridden by Vue in production.What does the proposed API look like?
This commit brings
Vue.config.performancein line withVue.config.devtools, by disabling it by default in production, but gives the developer the ability to explicitly ��enable it; for example, for debugging performance issues.Questions for reviewer:
packages/andsrc/platformsdoes. Advisement there would be appreciated