fix(compiler): nested scoped slot not update (fix #12232, #12245) #12265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuniorTour
force-pushed
the
fix-12232-nested-scoped-slot
branch
from
e5e063a to
041f514
Compare
|
Great! |
|
Is there anything that prevents this PR from being merged? 👀 |
We have to wait for code review and approval from official maintainer. 🤷♂️ |
posva
changed the title
|
Curious if this will be merged? It seems to fix the discrepancy between the old and new slot syntax, which is breaking some reactivity for us within nested slots. |
13 tasks
JuniorTour
force-pushed
the
fix-12232-nested-scoped-slot
branch
from
041f514 to
53a0d71
Compare
JuniorTour
force-pushed
the
fix-12232-nested-scoped-slot
branch
from
53a0d71 to
c2ec22e
Compare
|
Is there any plan for when to merged this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: