Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asyncComponent): unwrap default in Symbol.toStringTag es module hint #12320

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

869288142
Copy link

@869288142 869288142 commented Oct 11, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

in previous, rollup use Symbol.toStringTag hint indicate module is es module. user may hack methods get es module default like this ( ) => import('a.vue').then({ default } => default). user maybe remove this hack method

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

reproduction repo

image

I found the issue in the vite ssr offical explame. when i use () => import('lazy.vue'), it failed. I spent some time find vite production rollup option
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant