-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v-model): add lazy modifier for v-model on components(close #6914) #6940
Conversation
Any news on this? Is it going to get merged, and if so, when is it scheduled to get into an official release? Thanks. |
@javoski I think adding this feature should allow both using removed bad snippet of code, @javoski template solution is better or with a render function as well http://jsfiddle.net/dazvtwat/ I do agree to have |
@posva Yeah, it's reasonable for components to aware of if they are using const MyComp = {
...
template: `<input :value="value" @input="onUpdate" @change="onUpdate">`,
methods: {
onUpdate (e) {
this.$emit(e.type, e.target.value)
}
}
} |
That's much better, indeed, completely forgot about |
It would be nice for a component to actually know if the Native inputs will have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
@javoski Can you please look at the merge conflicts and try to get this merged? thanks a lot! |
@PhilipJohnBasile Please mege? :3 |
@javoski Awesome now that it is approved, can you please look at the conflicts and merge? thanks a lot! |
There's merge conflics @Tantawi |
Exciting. When can we merge? |
This PR was too old, so I opened a new one based on the latest codebase. #11830. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)Other information:
close #6914 .