Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StudioCMS guide and assets to CMS Section #11285

Merged
merged 19 commits into from
Mar 27, 2025
Merged

Add StudioCMS guide and assets to CMS Section #11285

merged 19 commits into from
Mar 27, 2025
+24 −0

Conversation

Adammatthiesen
Copy link
Contributor

Description (required)

This PR adds a new StudioCMS guide

Related issues & labels (optional)

  • Closes #
  • Suggested label: 3rd-party guide, add new content

Co-authored by @dreyfus92

@netlify Netlify
Copy link

netlify bot commented Mar 20, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 829c06b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67e556cdd09e6900082e829d
😎 Deploy Preview https://deploy-preview-11285--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Mar 20, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/cms/studiocms.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

dreyfus92
dreyfus92 reviewed Mar 20, 2025
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would add the svg file instead of the png which can be found in our docs and also the light one cause the badge is always dark for accessibility 😁

@Adammatthiesen
Copy link
Contributor Author

i would add the svg file instead of the png which can be found in our docs and also the light one cause the badge is always dark for accessibility 😁

fixed :D

dreyfus92
dreyfus92 reviewed Mar 20, 2025
View reviewed changes
louisescher
louisescher reviewed Mar 21, 2025
View reviewed changes
Copy link
Contributor

@louisescher louisescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick nit, other than that, great work!

@Adammatthiesen @louisescher
Update src/content/docs/en/guides/cms/studiocms.mdx
3d5fa4d 
Co-authored-by: Louis Escher <66965600+louisescher@users.noreply.github.com>
@ArmandPhilippot ArmandPhilippot added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. 3rd-party guide Community submitted CMS, deploy, backend etc. guide labels Mar 24, 2025
ArmandPhilippot
ArmandPhilippot reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone, this guide looks great! I just left a few suggestions, mostly nitpicks.

I got some errors in the terminal when completing onboarding/accessing the dashboard. But I believe this is more of a StudioCMS issue than a guide issue... and perhaps it's just me. So, LGTM!

Adammatthiesen and others added 2 commits March 24, 2025 06:15
@Adammatthiesen @ArmandPhilippot
Apply suggestions from code review
f977bef 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@Adammatthiesen @ArmandPhilippot
Update public/logos/studiocms.svg
fa14a89 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@Adammatthiesen
Copy link
Contributor Author

Adammatthiesen commented Mar 24, 2025 •
edited
Loading

Thanks everyone, this guide looks great! I just left a few suggestions, mostly nitpicks.

I got some errors in the terminal when completing onboarding/accessing the dashboard. But I believe this is more of a StudioCMS issue than a guide issue... and perhaps it's just me. So, LGTM!

@ArmandPhilippot It would be great if you could let us know in the StudioCMS discord server (maybe in a thread) about what issues you faced and what your setup is! We are looking to get to a stable non-beta version very soon!

ArmandPhilippot
ArmandPhilippot approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on my side! Thanks again! 🙌🏽 I just left a last nit so that the title is consistent with the format used in others guides.

I'm not merging yet, as this is new content and @sarah11918 might want to check the wording as a native speaker!
Also, I'm not sure if the discount code is a common thing (I mean if it's time-limited it might be a problem and a link where the code is displayed might be more appropriate), so I'd rather have confirmation first! 😄

@Adammatthiesen @ArmandPhilippot
Update src/content/docs/en/guides/cms/studiocms.mdx
4471ea4 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@Adammatthiesen
Copy link
Contributor Author

Also, I'm not sure if the discount code is a common thing (I mean if it's time-limited it might be a problem and a link where the code is displayed might be more appropriate), so I'd rather have confirmation first! 😄

Honestly, we can remove it if it is a problem, for now at least i know it is part of our relationship with them, and totally understandable if its not wanted on Astro Docs.

@sarah11918
Copy link
Member

Thanks for reveiwing, and then waiting @ArmandPhilippot ! Yes, I have two CMS guides in the stack here and they do both have to (at the end) go through me! hashtag-final-boss

On my plate for this week, Adam!

sarah11918
sarah11918 reviewed Mar 27, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! Thank you so much for your patience! Happy to finally have StudioCMS in docs! 🙌

Here are my thoughts/comments. See what you think!

@Adammatthiesen
Copy link
Contributor Author

OK! Thank you so much for your patience! Happy to finally have StudioCMS in docs! 🙌

Here are my thoughts/comments. See what you think!

@sarah11918 I've updated a few things for clarity, as well as fixed a few of the links that i didn't notice that where invalid.

Adammatthiesen and others added 2 commits March 27, 2025 06:36
@Adammatthiesen @sarah11918
Update src/content/docs/en/guides/cms/studiocms.mdx
b9f92b1 
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
@Adammatthiesen
Update studiocms.mdx
7da292d
@delucis @sarah11918
Remove stub frontmatter
e966866 
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
yanthomasdev
yanthomasdev reviewed Mar 27, 2025
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit!

delucis
delucis approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A studio in concision 🙌

@Adammatthiesen @yanthomasdev
Update src/content/docs/en/guides/cms/studiocms.mdx
829c06b 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@sarah11918 sarah11918 merged commit 0def794 into withastro:main Mar 27, 2025
10 checks passed
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Mar 27, 2025
@ArmandPhilippot
i18n(fr): add guides/cms/studiocms.mdx
ca23767 
See withastro#11285
@ArmandPhilippot ArmandPhilippot mentioned this pull request Mar 27, 2025
Merged
thomasbnt pushed a commit that referenced this pull request Mar 27, 2025
@ArmandPhilippot
i18n(fr): add guides/cms/studiocms.mdx (#11310)
d2148dd 
See #11285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918

@yanthomasdev yanthomasdev

@louisescher louisescher

@JusticeMatthew JusticeMatthew

@dreyfus92 dreyfus92

@delucis delucis

@ArmandPhilippot ArmandPhilippot

Assignees
No one assigned
Labels
3rd-party guide Community submitted CMS, deploy, backend etc. guide add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Adammatthiesen @astrobot-houston @sarah11918 @delucis @ArmandPhilippot @yanthomasdev @louisescher @JusticeMatthew @dreyfus92