RFC: fix: FatalError set reference to causing error #1257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run doc
(not part of external api)Description
FatalError does not provide enough context for understanding underlying issues.
Where available, attach the "causing" error to the FatalError to allow later inspection on
.cause
(see https://nodejs.org/api/errors.html#errorcause)Serializing Error objects with
util.inspect()
recursively serializeserror.cause
if it is set and would allow better log messages in consuming applications.I don't believe the existing approach of copying of the stack from the causing error is "least surprise" for consuming authors, but I do not yet understand reasons for why it is as is, or likelihood of breaking existing code.
References
Recent node versions introduced a bug (nodejs/node#54359) in certain network configurations that is becoming more numerous triggering EFATAL errors.
Reports often miss much depth, with only "EFATAL: AggregateError" as a description: