Skip to content

Commit 42ae6ce

Browse files
committed
update minutes action to work as documented:
Zencoder::Report.minutes(:from => "2013-12-27", :to => "2014-01-03") instead of Zencoder::Report.minutes(:params => {:from => "2013-12-27", :to => "2014-01-03"})
1 parent 1ad607a commit 42ae6ce

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

lib/zencoder/report.rb

+10-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,16 @@ module Zencoder
22
class Report < Resource
33

44
def self.minutes(options={})
5-
get("/reports/minutes", options)
5+
options = options.dup
6+
params = {
7+
:from => options.delete(:from),
8+
:to => options.delete(:to),
9+
:grouping => options.delete(:grouping)
10+
}
11+
12+
params.delete_if { |k, v| v.nil? }
13+
14+
get("/reports/minutes", merge_params(options, params))
615
end
716

817
end

test/zencoder/reports_test.rb

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,16 @@ class Zencoder::ReportTest < Test::Unit::TestCase
1313
:to => "2011-06-01",
1414
:grouping => "foo"},
1515
:headers => { "Zencoder-Api-Key" => @api_key }}).returns(Zencoder::Response.new)
16-
assert_equal Zencoder::Response, Zencoder::Report.minutes(:api_key => @api_key, :params => { :from => "2011-01-01",
17-
:to => "2011-06-01",
18-
:grouping => "foo" }).class
16+
assert_equal Zencoder::Response, Zencoder::Report.minutes(:api_key => @api_key, :from => "2011-01-01",
17+
:to => "2011-06-01",
18+
:grouping => "foo").class
1919
end
2020

2121
should "merge params well" do
2222
Zencoder::HTTP.stubs(:get).with(@url, {:params => { :from => "2011-01-01",
2323
:to => "2011-06-01"},
2424
:headers => { "Zencoder-Api-Key" => @api_key }}).returns(Zencoder::Response.new)
25-
assert_equal Zencoder::Response, Zencoder::Report.minutes(:api_key => @api_key, :params => {:from => "2011-01-01", :to => "2011-06-01"}).class
25+
assert_equal Zencoder::Response, Zencoder::Report.minutes(:api_key => @api_key, :from => "2011-01-01", :to => "2011-06-01").class
2626
end
2727
end
2828

0 commit comments

Comments
 (0)