Skip to content

Improve brew doctor warnings about xattr and cask quarantine #20153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Jun 22, 2025

Follow-up to #20151 and #20152

On Linux with a cask installed, brew doctor displays some unhelpful warnings about xattr and cask quarantine. This PR attempts to improve those.

Before:

$ brew doctor 
Warning: No Cask quarantine support available: there's no working version of `xattr` on this system.
/usr/bin/env: ‘/usr/bin/xattr’: No such file or directory

Warning: unknown xattr error: /usr/bin/env: ‘/usr/bin/xattr’: No such file or directory

After:

$ brew doctor
Warning: No Cask quarantine support available: not available on Linux.

Warning: Unable to find `xattr`.

Note: it might be better to not even run the check_cask_xattr if there is no quarantine support anyway, but I wasn’t 100% sure whether xattr was used for anything except quarantine.

Also, this PR was not made against the master branch because it depends on some of the work in #20152

Base automatically changed from extend-os-class-methods to master June 22, 2025 02:33
@Rylan12 Rylan12 marked this pull request as draft June 22, 2025 02:40
@Rylan12 Rylan12 force-pushed the brew-doctor-linux-cask-errors branch from 05ed8d5 to 12e5e24 Compare June 22, 2025 18:25
@Rylan12 Rylan12 marked this pull request as ready for review June 22, 2025 19:01
@MikeMcQuaid
Copy link
Member

Note: it might be better to not even run the check_cask_xattr if there is no quarantine support anyway, but I wasn’t 100% sure whether xattr was used for anything except quarantine.

Yeh, I think so. This message is still better than the status quo, though, so lets punt that to a follow-up.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 23, 2025
Merged via the queue into master with commit 984273b Jun 23, 2025
40 checks passed
@MikeMcQuaid MikeMcQuaid deleted the brew-doctor-linux-cask-errors branch June 23, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants