Improve brew doctor
warnings about xattr
and cask quarantine
#20153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #20151 and #20152
On Linux with a cask installed,
brew doctor
displays some unhelpful warnings aboutxattr
and cask quarantine. This PR attempts to improve those.Before:
After:
Note: it might be better to not even run the
check_cask_xattr
if there is no quarantine support anyway, but I wasn’t 100% sure whetherxattr
was used for anything except quarantine.Also, this PR was not made against the
master
branch because it depends on some of the work in #20152