create: detect URL from latest release if it isn't archive #20156
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Jun 23, 2025
Please always do these before opening a PR. There's legit failures in https://github.com/Homebrew/brew/actions/runs/15821654438/job/44592172254?pr=20156 |
abitrolly
force-pushed
the
url-from-latest-release
branch
from
835ebf0 to
cd23c23
Compare
|
@MikeMcQuaid I simplified the logic. If version is fetched from the latest release, the URL also made to point to its source code. Without additional fetch. |
MikeMcQuaid
approved these changes
Jun 25, 2025
|
@abitrolly Thanks! |
Detects source archive for GitHub URL without version. Both releases and tags share the same URL pattern for source archive https://github.com/Homebrew/brew/releases https://github.com/Homebrew/brew/tags
abitrolly
force-pushed
the
url-from-latest-release
branch
from
ed0255e to
3e36e98
Compare
|
@MikeMcQuaid rebased and squashed. |
MikeMcQuaid
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?When running
brew create https://github.com/buildpacks/packthe version is not detected from the URL, so the version from the latest release is used. But the URL still doesn't point to the source code archive. This PR constructs the URL to point to the source archive for the detected release or tag.