-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Open
Labels
feature requestNew feature or request to improve the current logicNew feature or request to improve the current logic
Description
Description:
If we pass a absolute path to node-version-file
, for example, when using with Composite Actions, the resulting path is resolved incorrectly, due to a path.join()
call.
Lines 96 to 100 in 5e21ff4
if (versionFileInput) { | |
const versionFilePath = path.join( | |
process.env.GITHUB_WORKSPACE!, | |
versionFileInput | |
); |
Action version:
v3
Platform:
- Ubuntu
- macOS
- Windows
Runner type:
- Hosted
- Self-hosted
Tools version:
Repro steps:
- In a composite action with
.nvmrc
, use following as input:node-version-file: ${{ github.action_path }}/.nvmrc
Example broken action run: https://github.com/sidvishnoi/mediasession/actions/runs/6158104300/job/16710218833?pr=1
Expected behavior:
If it can check whether provided node-version-file
exists as is, or perhaps use path.resolve()
, it won't break with absolute paths.
Actual behavior:
Error: The specified node version file at: /home/runner/work/mediasession/mediasession/home/runner/work/_actions/w3c/spec-prod/fix-nvmrc/.nvmrc does not exist
^^^
vincentclee, atsu85, marknuzz, paddyroddy, comatory and 4 more
Metadata
Metadata
Assignees
Labels
feature requestNew feature or request to improve the current logicNew feature or request to improve the current logic