Updated Parsing to Support Filename: and Longer Commit Hashes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched from txt to markdown and expanded the readme a little
Added support for filename: to be in the log. Updated commitid: so that it can have hashes between 10 and 20 chars
F/update parsing
| @@ -450,8 +450,10 @@ void begin(char *s, size_t l) | |||
| <ATR1>-[0-9]+;\ \ BEGIN ATR0; rfile.revt->ldel = atoi(yytext+1); | |||
| <ATR0>kopt:\ [^;\n]+;\n BEGIN REV3; rfile.revt->kopt = getstr(yyleng-8, yytext+6); | |||
| <ATR0>kopt:\ [^;\n]+;\ \ rfile.revt->kopt = getstr(yyleng-9, yytext+6); | |||
| <ATR0>commitid:\ [0-9a-f]{16};\ \ rfile.revt->commitid = getstr(16, yytext+10); | |||
| <ATR0>commitid:\ [0-9a-f]{16};\n BEGIN REV3; rfile.revt->commitid = getstr(16, yytext+10); | |||
| <ATR0>commitid:\ [0-9a-f]{10,20};\ \ rfile.revt->commitid = getstr(yyleng-11, yytext+10); | |||
There was a problem hiding this comment.
Sorry if I misunderstand stuff here (I wasn't able to google up getstr easily somehow), but shouldn't it be maybe yyleng-13 to account for the 2 escaped spaces at the end too? And in the next line, shouldn't this be yyleng-12 for the newline?
There was a problem hiding this comment.
getstr() is defined in the file (which I realized after my failed Googling too). I think you're right though. I'll go over what I was thinking and update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the parsing so that it:
Move the readme into a markdown file and added in sections from the cvsclone.l header so it's a little easier to read.