variable-length-quantity: add more test cases #2576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
force-pushed
the
additional-variable-length-quantity-test-cases
branch
2 times, most recently
from
5f3fc22 to
54c38f6
Compare
The existing test cases are all either: - Ending or beginning with a 1 - All ones or all zeros This could lead to faulty implementations
ErikSchierboom
force-pushed
the
additional-variable-length-quantity-test-cases
branch
from
54c38f6 to
ed0915e
Compare
|
I was unsure what to call these new test cases. Suggestions are more than welcome |
IsaacG
approved these changes
Jun 27, 2025
glennj
approved these changes
Jun 27, 2025
|
The test descriptions seem reasonable to me. |
keiravillekode
approved these changes
Jun 28, 2025
ErikSchierboom
deleted the
additional-variable-length-quantity-test-cases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing test cases are all either:
This could lead to faulty implementations