Skip to content

Commit f2f0146

Browse files
committed
Add "overlay" to SARIF incrementalMode run property
1 parent 455a24e commit f2f0146

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

src/analyze.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import { EnvVar } from "./environment";
2525
import { FeatureEnablement, Feature } from "./feature-flags";
2626
import { isScannedLanguage, Language } from "./languages";
2727
import { Logger, withGroupAsync } from "./logging";
28+
import { OverlayDatabaseMode } from "./overlay-database-utils";
2829
import { getRepositoryNwoFromEnv } from "./repository";
2930
import { DatabaseCreationTimings, EventReport } from "./status-report";
3031
import { endTracingForCluster } from "./tracer-config";
@@ -576,6 +577,7 @@ export async function runQueries(
576577
): Promise<QueriesStatusReport> {
577578
const statusReport: QueriesStatusReport = {};
578579
const queryFlags = [memoryFlag, threadsFlag];
580+
const incrementalMode: string[] = [];
579581

580582
if (cleanupLevel !== "overlay") {
581583
queryFlags.push("--expect-discarded-cache");
@@ -585,10 +587,18 @@ export async function runQueries(
585587
if (diffRangePackDir) {
586588
queryFlags.push(`--additional-packs=${diffRangePackDir}`);
587589
queryFlags.push("--extension-packs=codeql-action/pr-diff-range");
590+
incrementalMode.push("diff-informed");
588591
}
589-
const sarifRunPropertyFlag = diffRangePackDir
590-
? "--sarif-run-property=incrementalMode=diff-informed"
591-
: undefined;
592+
if (
593+
config.augmentationProperties.overlayDatabaseMode ===
594+
OverlayDatabaseMode.Overlay
595+
) {
596+
incrementalMode.push("overlay");
597+
}
598+
const sarifRunPropertyFlag =
599+
incrementalMode.length > 0
600+
? `--sarif-run-property=incrementalMode=${incrementalMode.join(",")}`
601+
: undefined;
592602

593603
const codeql = await getCodeQL(config.codeQLCmd);
594604

0 commit comments

Comments
 (0)