Skip to content

Fix Unicode in cert-help-extraction.py #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 8, 2022
Merged

Fix Unicode in cert-help-extraction.py #35

merged 8 commits into from
Aug 8, 2022

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Jul 29, 2022

Description

  • Optionally specify rule ids in cert-help-extraction.py
  • Normalize Unicode data
  • Add VSC task to extract CERT help files

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql, .qll, .qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • rule number here
  • Queries have been modified for the following rules:
    • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

Normalize Unicode data
@mbaluda mbaluda changed the title Normalize of Unicode characters Fix Unicode in cert-help-extraction.py Aug 4, 2022
@mbaluda mbaluda requested review from rvermeulen and jsinglet August 4, 2022 16:34
@mbaluda mbaluda marked this pull request as ready for review August 4, 2022 23:47
Copy link
Contributor

@jsinglet jsinglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @mbaluda -- this is working with the exception that by default it changes the line endings from LF -> CRLF. I think just specifying the line ending type will fix it. Git normalizes files but I am not sure if we want the python script to un-normalize line endings? When you do a git diff it shows up as changed when running it on an existing rule.

@mbaluda mbaluda requested a review from jsinglet August 5, 2022 20:50
Copy link
Contributor

@jsinglet jsinglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌 Looks good!!! Ran it with no problems this time.

@mbaluda mbaluda merged commit d2e0cbc into main Aug 8, 2022
@mbaluda mbaluda deleted the mbaluda-patch-1 branch August 8, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants