Merge pull request #19675 from github/smowton/fix/abstract-env

smowton · web-flow · commit fbae3062d39a · 2025-06-05T16:50:11.000+01:00
Actions: Make `Env` non-abstract
diff --git a/actions/ql/lib/codeql/actions/Ast.qll b/actions/ql/lib/codeql/actions/Ast.qll
@@ -50,8 +50,8 @@ class Expression extends AstNode instanceof ExpressionImpl {
   string getNormalizedExpression() { result = normalizeExpr(expression) }
 }
 
-/** A common class for `env` in workflow, job or step. */
-abstract class Env extends AstNode instanceof EnvImpl {
+/** An `env` in workflow, job or step. */
+class Env extends AstNode instanceof EnvImpl {
   /** Gets an environment variable value given its name. */
   ScalarValueImpl getEnvVarValue(string name) { result = super.getEnvVarValue(name) }
 

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,8 @@ class Expression extends AstNode instanceof ExpressionImpl {`
`50`	`50`	`string getNormalizedExpression() { result = normalizeExpr(expression) }`
`51`	`51`	`}`
`52`	`52`
`53`		-/** A common class for `env` in workflow, job or step. */
`54`		`-abstract class Env extends AstNode instanceof EnvImpl {`
	`53`	+/** An `env` in workflow, job or step. */
	`54`	`+class Env extends AstNode instanceof EnvImpl {`
`55`	`55`	`/** Gets an environment variable value given its name. */`
`56`	`56`	`ScalarValueImpl getEnvVarValue(string name) { result = super.getEnvVarValue(name) }`
`57`	`57`