Go: Fix missing flow through receiver for function variable (try 2) #13861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
previously approved these changes
Aug 1, 2023
owen-mc
dismissed
smowton’s stale review
The merge-base changed after approval.
owen-mc
force-pushed
the
go/missing-flow-through-receiver-2
branch
from
d63909e to
39c7baa
Compare
|
Performance testing showed severe problems. I'm putting this into draft until I've had a chance to fix that. |
When a function is assigned to a variable and called through that variable then we can't always tell it wis a method. With this change we try use local flow to determine if the function being called is a method.
This is not required, because getReceiver is still defined on CallNode, but is done for consistency.
owen-mc
force-pushed
the
go/missing-flow-through-receiver-2
branch
from
39c7baa to
e91b7f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstate #13767 (reverted here). Based on #13785 which fixes
golangSpecificParamArgFilterin a better way which doesn't ruin performance.When assigning a method to a function variable (f := a.b) and calling it using the variable (f(arg1, arg2)), we were losing any possible flow to the receiver of the method.