Go: improve CallNode documentation #14882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a function is assigned to a variable and called through that variable then we can't always tell it was a method.
smowton
previously approved these changes
Nov 22, 2023
|
The performance evaluation was bad for very large codebases. I will make this a draft until I can look into why. |
owen-mc
force-pushed
the
go/minor-fixes
branch
from
13b4b28 to
dd8fb29
Compare
|
I've dropped the code changes from this PR. I will look into why they cause performance problems separately. So this PR is now just docs changes. |
owen-mc
changed the title
smowton
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the uncontroversial parts of #13861. That PR had performance problems, and it may be closed without merging, but it would be a shame to lose these improvements.