C++: Autoformat IR SSA files #1928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
reviewed
Sep 12, 2019
| cached Instruction getInstructionSuccessor(Instruction instruction, EdgeKind kind) { | ||
| if(hasChiNode(_, getOldInstruction(instruction))) | ||
|
|
||
| cached |
There was a problem hiding this comment.
I think the above was intended to be a QLDoc comment attached to the predicate.
There was a problem hiding this comment.
Good catch. I'll fix that.
One autoformat omission had also slipped into `DefaultTaintTracking.qll`.
Let's give @dave-bartolomeo a chance to react to this PR in his time zone. Then we can merge tomorrow if there are no objections. |
dave-bartolomeo
approved these changes
Sep 12, 2019
| // A `Chi` instruction consumes the enclosing virtual variable of its use location. | ||
| hasChiNode(defLocation, use) | ||
| ) | ||
| else ( | ||
| ) else ( |
There was a problem hiding this comment.
I find this kind of inconsistent with the usual pattern if the if, then, and else being vertically aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One autoformat omission had also slipped into
DefaultTaintTracking.qll. When everything is autoformatted after this PR, we can set up a PR check for autoformat.I've searched for all comments that change in the diff, and they look good to me. This will conflict with #1736, but @dave-bartolomeo has given the green light anyway.