Skip to content

QL tests: run with --check-diff-informed #19428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Apr 30, 2025

No description provided.

@github-actions github-actions bot added the Ruby label Apr 30, 2025
@d10c
Copy link
Contributor

d10c commented Apr 30, 2025

Note: another language that (currently) only has tests in github/codeql is Go:

codeql/go/Makefile

Lines 57 to 58 in a46f8fb

codeql test run -j0 ql/test --search-path .. --consistency-queries ql/test/consistency --compilation-cache=$(cache) --dynamic-join-order-mode=$(rtjo)
# use GOOS=linux because GOOS=darwin GOARCH=386 is no longer supported

https://github.com/github/codeql/blob/a46f8fb0d9533114f3c634d7ec1e09f4c8b1c505/go/actions/test/action.yml#L81-L82
uses: ./go/actions/test
with:

@cklin cklin force-pushed the cklin/check-diff-informed branch from 4dbf42e to 481afb8 Compare April 30, 2025 17:15
@github-actions github-actions bot added the Go label Apr 30, 2025
@cklin cklin force-pushed the cklin/check-diff-informed branch from 481afb8 to 5bc962c Compare April 30, 2025 17:56
@cklin cklin marked this pull request as ready for review April 30, 2025 18:47
@Copilot Copilot AI review requested due to automatic review settings April 30, 2025 18:47
@cklin cklin requested review from a team as code owners April 30, 2025 18:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates various CodeQL test commands to include the new --check-diff-informed flag, ensuring tests also evaluate diff-related checks.

  • Updated test target in ruby/Makefile
  • Modified CodeQL test commands in go/Makefile
  • Added the flag to CodeQL test runs in multiple GitHub workflow files (.github/workflows/ruby-qltest.yml, ruby-qltest-rtjo.yml, and csharp-qltest.yml)

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ruby/Makefile Added --check-diff-informed flag in the test target command.
go/Makefile Inserted --check-diff-informed flag into test commands.
.github/workflows/ruby-qltest.yml Updated test run command with the new flag.
.github/workflows/ruby-qltest-rtjo.yml Updated test run command with the new flag.
.github/workflows/csharp-qltest.yml Updated test run command with the new flag.

@cklin cklin requested a review from d10c May 28, 2025 17:48
@cklin
Copy link
Contributor Author

cklin commented May 28, 2025

@d10c Thank you for your comment about Go! I totally missed that.

I added you as reviewer for this PR.

Since all that this PR does is to standardize QL testing across languages, and you have experience in this area, I think your approval would be sufficient to merge this change.

Please let me know if you have any further feedback!

Copy link
Contributor

@d10c d10c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this covers all the github/codeql language tests, so LGTM.

@cklin cklin merged commit b4e614a into main May 28, 2025
26 checks passed
@cklin cklin deleted the cklin/check-diff-informed branch May 28, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants