-
Notifications
You must be signed in to change notification settings - Fork 1.7k
QL tests: run with --check-diff-informed #19428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: another language that (currently) only has tests in github/codeql is Go: Lines 57 to 58 in a46f8fb
https://github.com/github/codeql/blob/a46f8fb0d9533114f3c634d7ec1e09f4c8b1c505/go/actions/test/action.yml#L81-L82 codeql/.github/workflows/go-tests.yml Lines 38 to 39 in a46f8fb
|
4dbf42e
to
481afb8
Compare
481afb8
to
5bc962c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates various CodeQL test commands to include the new --check-diff-informed flag, ensuring tests also evaluate diff-related checks.
- Updated test target in ruby/Makefile
- Modified CodeQL test commands in go/Makefile
- Added the flag to CodeQL test runs in multiple GitHub workflow files (.github/workflows/ruby-qltest.yml, ruby-qltest-rtjo.yml, and csharp-qltest.yml)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
ruby/Makefile | Added --check-diff-informed flag in the test target command. |
go/Makefile | Inserted --check-diff-informed flag into test commands. |
.github/workflows/ruby-qltest.yml | Updated test run command with the new flag. |
.github/workflows/ruby-qltest-rtjo.yml | Updated test run command with the new flag. |
.github/workflows/csharp-qltest.yml | Updated test run command with the new flag. |
@d10c Thank you for your comment about Go! I totally missed that. I added you as reviewer for this PR. Since all that this PR does is to standardize QL testing across languages, and you have experience in this area, I think your approval would be sufficient to merge this change. Please let me know if you have any further feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this covers all the github/codeql language tests, so LGTM.
No description provided.