C++/C#: Cleanup in preparation for indirect alias analysis #2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `bitsToBytesAndBits` omit the leftover bits if zero.
jbj
reviewed
Nov 25, 2019
cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/IRVariable.qll
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,2 @@ | |||
| private import SSAConstruction as SSA | |||
| import SSA::SSASanity | |||
There was a problem hiding this comment.
Why do we need this file? Can't we just write import SSAConstruction::SSASanity in SSASanity.ql?
There was a problem hiding this comment.
I think we could get rid of it, but it does fit the pattern we've used for IRSanity.qll, where each sanity query .ql file is just some metadata (which has to be specialized for the flavor of the IR) plus a single import.
There was a problem hiding this comment.
Okay. We can come back to this question as part of a later reform of the sanity code (moving it out of Instruction.qll).
|
On ChakraCore, I measured a performance speedup of 5% with these changes, which is probably within the measurement error for running perf numbers on my laptop. |
|
Tests are failing. |
jbj
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the first several commits from #1736, appropriately fixed up to handle the introduction of the IR type system and the sharing of the IR code with C#. These are all just cleanup and refactoring changes that came out of the indirect alias analysis work. I figured I'd get them in now, to avoid having them bit rot while I finish getting the rest of that PR in shape.