Skip to content

Add missing java.nio.file.Files methods to FileReadWrite.qll #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 requested a review from a team as a code owner June 26, 2020 17:38
@aschackmull
Copy link
Contributor

LGTM, but could you please autoformat? Otherwise the PR check will fail.

@Marcono1234
Copy link
Contributor Author

Sorry for the delay. Formatted the file now and force pushed (due to the low number of changed files, hope this is alright).
I also noticed that it was previously erroneously looking for a method called newInputReader instead of newInputStream, which I have fixed as well.

@aschackmull
Copy link
Contributor

There is a zero-width space (U+200B) after "newInputStream, which causes PR checks to fail and would mean that the code wouldn't actually match a newInputStream call.

@Marcono1234
Copy link
Contributor Author

Sorry for the trouble and good that you noticed it! I copied it from https://docs.oracle.com/en/java/javase/14/docs/api/index.html (to prevent any typos), but sadly the method names have this \u200B before the opening parenthesis.

@aschackmull aschackmull merged commit 993506d into github:master Jul 7, 2020
@Marcono1234 Marcono1234 deleted the patch-2 branch July 8, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants