Skip to content

Do not exclude schema keyword if schema has description #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

benjie
Copy link
Member

@benjie benjie commented May 19, 2025

This is a bugfix; previously we said that the schema keyword can/should be omitted if the root operation type names line up, but we neglected to think about the schema description. This fixes that.

Trivial fix @graphql/tsc

(Discussed as part of #1166, but since there's pushback to the naked schema keyword I'm separating this out into its own standalone fix.)

@benjie benjie added the 💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md) label May 19, 2025
Copy link

netlify bot commented May 19, 2025

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit c11671d
🔍 Latest deploy log https://app.netlify.com/projects/graphql-spec-draft/deploys/682aee1d3c48460008ad447c
😎 Deploy Preview https://deploy-preview-1167--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@leebyron leebyron added 📄 Draft (RFC 2) RFC Stage 2 (See CONTRIBUTING.md) and removed 💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md) labels Jun 5, 2025
@leebyron
Copy link
Collaborator

leebyron commented Jun 5, 2025

Jumping to RFC2 - waiting on GraphQL.js unit tests to confirm this behavior

Copy link

@Muaytie666 Muaytie666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjie benjie added the 🚀 Next Stage? This RFC believes it is ready for the next stage label Jun 26, 2025
@benjie
Copy link
Member Author

benjie commented Jun 26, 2025

GraphQL.js test passes: graphql/graphql-js#4441

yaacovCR pushed a commit to graphql/graphql-js that referenced this pull request Jun 26, 2025
@leebyron leebyron added 🏁 Accepted (RFC 3) RFC Stage 3 (See CONTRIBUTING.md) and removed 📄 Draft (RFC 2) RFC Stage 2 (See CONTRIBUTING.md) 🚀 Next Stage? This RFC believes it is ready for the next stage labels Jun 26, 2025
@leebyron leebyron merged commit 883c759 into main Jun 26, 2025
9 checks passed
@leebyron leebyron deleted the fix-schema-keyword branch June 26, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Accepted (RFC 3) RFC Stage 3 (See CONTRIBUTING.md)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants