-
Notifications
You must be signed in to change notification settings - Fork 9.4k
issue-21446, removing commerce modules from open-source #40041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
issue-21446, removing commerce modules from open-source #40041
Conversation
Hi @jakwinkler. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes commerce-specific frontend modules from the open-source Magento distribution by deleting their design (LESS) and layout files.
- Deletes LESS source files for RMA, Reward, MultipleWishlist, GiftWrapping, GiftRegistry, GiftMessage, GiftCardAccount, GiftCard, CustomerBalance, AdvancedCheckout, VersionsCms, CatalogEvent, Banner, and other commerce modules under both
luma
andblank
themes, as well as adminhtml theme files. - Removes the cart layout move for the GiftCardAccount module.
- Cleans up commerce-only CSS and widget definitions from the open-source codebase.
Reviewed Changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
app/design/frontend/Magento/luma/Magento_Rma/web/css/source/_module.less | Removed RMA module styles |
app/design/frontend/Magento/luma/Magento_Reward/web/css/source/_module.less | Removed Reward module styles |
app/design/frontend/Magento/luma/Magento_MultipleWishlist/web/css/source/_module.less | Removed MultipleWishlist styles |
app/design/frontend/Magento/luma/Magento_GiftWrapping/web/css/source/_module.less | Removed GiftWrapping styles |
app/design/frontend/Magento/luma/Magento_GiftRegistry/web/css/source/_module.less | Removed GiftRegistry styles |
app/design/frontend/Magento/luma/Magento_GiftMessage/web/css/source/_module.less | Removed GiftMessage styles |
app/design/frontend/Magento/luma/Magento_GiftCardAccount/web/css/source/_module.less | Removed GiftCardAccount styles |
app/design/frontend/Magento/luma/Magento_GiftCardAccount/layout/checkout_cart_index.xml | Removed GiftCardAccount cart layout customization |
... | (Additional commerce module LESS and widget files all deleted) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK both themes are not used in Adobe Commerce, so shouldn't be any issues. Approving.
Fixed Issues (if relevant)
Contribution checklist (*)