Skip to content

issue-21446, removing commerce modules from open-source #40041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

jakwinkler
Copy link

Fixed Issues (if relevant)

  1. Fixes Community themes contain resources for Commerce edition modules #21446

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Jul 4, 2025

Hi @jakwinkler. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Bravo engcom-Bravo added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Jul 8, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jul 8, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes commerce-specific frontend modules from the open-source Magento distribution by deleting their design (LESS) and layout files.

  • Deletes LESS source files for RMA, Reward, MultipleWishlist, GiftWrapping, GiftRegistry, GiftMessage, GiftCardAccount, GiftCard, CustomerBalance, AdvancedCheckout, VersionsCms, CatalogEvent, Banner, and other commerce modules under both luma and blank themes, as well as adminhtml theme files.
  • Removes the cart layout move for the GiftCardAccount module.
  • Cleans up commerce-only CSS and widget definitions from the open-source codebase.

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/design/frontend/Magento/luma/Magento_Rma/web/css/source/_module.less Removed RMA module styles
app/design/frontend/Magento/luma/Magento_Reward/web/css/source/_module.less Removed Reward module styles
app/design/frontend/Magento/luma/Magento_MultipleWishlist/web/css/source/_module.less Removed MultipleWishlist styles
app/design/frontend/Magento/luma/Magento_GiftWrapping/web/css/source/_module.less Removed GiftWrapping styles
app/design/frontend/Magento/luma/Magento_GiftRegistry/web/css/source/_module.less Removed GiftRegistry styles
app/design/frontend/Magento/luma/Magento_GiftMessage/web/css/source/_module.less Removed GiftMessage styles
app/design/frontend/Magento/luma/Magento_GiftCardAccount/web/css/source/_module.less Removed GiftCardAccount styles
app/design/frontend/Magento/luma/Magento_GiftCardAccount/layout/checkout_cart_index.xml Removed GiftCardAccount cart layout customization
... (Additional commerce module LESS and widget files all deleted)

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK both themes are not used in Adobe Commerce, so shouldn't be any issues. Approving.

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for testing Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Ready for Testing
Development

Successfully merging this pull request may close these issues.

Community themes contain resources for Commerce edition modules
4 participants