Added ConversationAccountConverter #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ML: Core
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for converting ConversationAccount objects during JSON serialization and deserialization, and includes a new test to ensure round-trip consistency.
- Added unit tests to verify ConversationAccount round-trip serialization
- Registered the new ConversationAccountConverter in the serialization pipeline
- Implemented the ConversationAccountConverter to handle extension data
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tests/Microsoft.Agents.Model.Tests/ConversationAccountTests.cs | Added unit tests validating JSON round-trip serialization for ConversationAccount |
| src/libraries/Core/Microsoft.Agents.Core/Serialization/ProtocolJsonSerializer.cs | Registered ConversationAccountConverter with the JSON serializer options |
| src/libraries/Core/Microsoft.Agents.Core/Serialization/Converters/ConversationAccountConverter.cs | Implemented a converter to process ConversationAccount extension data |
...ibraries/Core/Microsoft.Agents.Core/Serialization/Converters/ConversationAccountConverter.cs
Show resolved
Hide resolved
MattB-msft
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276