Skip to content

Restored original EnsureTrailingSlash #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

tracyboehrer
Copy link
Member

@tracyboehrer tracyboehrer commented May 13, 2025

Fixes #278

Dueling merges caused a bit of confusion.

@Copilot Copilot AI review requested due to automatic review settings May 13, 2025 22:05
@tracyboehrer tracyboehrer requested a review from a team as a code owner May 13, 2025 22:05
@tracyboehrer tracyboehrer enabled auto-merge May 13, 2025 22:05
@github-actions github-actions bot added the ML: Core Tags changes to core libraries label May 13, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the original behavior of the EnsureTrailingSlash method to address issue #278.

  • Changes the access modifier from public to internal, aligning with the intended API design.
  • Updates the trailing slash condition check by replacing Contains with EndsWith for accuracy.
Comments suppressed due to low confidence (2)

src/libraries/Client/Microsoft.Agents.Connector/RestClients/UriExtensions.cs:34

  • Changing the access modifier from public to internal will restrict external access; verify that this change is intended based on the original API design.
internal static Uri EnsureTrailingSlash(this Uri uri)

src/libraries/Client/Microsoft.Agents.Connector/RestClients/UriExtensions.cs:40

  • Replacing the condition from Contains to EndsWith correctly targets the trailing slash; ensure that all potential URI formats are properly handled.
if (!uriString.EndsWith('/'))

@tracyboehrer tracyboehrer merged commit 2a45fb0 into main May 13, 2025
8 checks passed
@tracyboehrer tracyboehrer deleted the users/tracyboehrer/trailing-slash branch May 13, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ML: Core Tags changes to core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EmptyAgent fails in Teams App Test Tool with 404
2 participants