Improve version retrieval in UserAgent.cs #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated version retrieval logic to use FileVersionInfo for more accurate versioning. Added error handling to fall back to assembly name version if file version is unavailable. Included necessary namespace for diagnostics.
There was a problem hiding this comment.
Pull Request Overview
This PR improves the version retrieval logic in UserAgent.cs by using FileVersionInfo to obtain a more accurate version, and adds error handling to fall back to the assembly name version if necessary.
- Updates the version retrieval method to use FileVersionInfo
- Adds error handling via a try-catch block
- Includes the necessary System.Diagnostics namespace
rido-min
reviewed
May 14, 2025
tracyboehrer
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version retrieval logic to use FileVersionInfo for more accurate versioning. Added error handling to fall back to assembly name version if file version is unavailable. Included necessary namespace for diagnostics.