Skip to content

AdaptiveCardInvokeResponseFactory fixes #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 16, 2025
Merged

AdaptiveCardInvokeResponseFactory fixes #296

merged 6 commits into from
May 16, 2025

Conversation

tracyboehrer
Copy link
Member

@tracyboehrer tracyboehrer commented May 16, 2025 •
edited
Loading

Fixes #295
Fixes #287

  • Changed AdaptiveCardInvokeResponseFactory.AdaptiveCard to accept a string value (instead of an AdaptiveCard instance)
  • Added variations for the BadRequest responses ActivityHandler defined.
  • This removes the AdaptiveCard and NewtonSoft dependencies. Apparently, they were only there for the original AdaptiveCardInvokeResponseFactory.AdaptiveCard helper.
  • Removing NewtonSoft also exposed a bug in a Compat sample, which is nice.

@Copilot Copilot AI review requested due to automatic review settings May 16, 2025 13:40
@tracyboehrer tracyboehrer requested a review from a team as a code owner May 16, 2025 13:40
Copilot
Copilot AI reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the AdaptiveCardInvokeResponse was incorrectly assigned an AdaptiveCard object instead of its JSON representation.

  • Renames the parameter from "adaptiveCard" to "adaptiveCardJson"
  • Changes the type of the parameter from AdaptiveCard to string and updates the assignment accordingly

@github-actions github-actions bot added the ML: Core Tags changes to core libraries label May 16, 2025
@tracyboehrer tracyboehrer enabled auto-merge May 16, 2025 15:15
@tracyboehrer tracyboehrer changed the title AdaptiveCardInvokeResponseFactory.AdaptiveCard accepts wrong Value content AdaptiveCardInvokeResponseFactory fixes May 16, 2025
@github-actions github-actions bot added the ML: Samples Tags changes to samples label May 16, 2025
@tracyboehrer tracyboehrer merged commit aa1e909 into main May 16, 2025
8 checks passed
@tracyboehrer tracyboehrer deleted the users/tracyboehrer/ac-fixes branch May 16, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot

@MattB-msft MattB-msft

Assignees
No one assigned
Labels
ML: Core Tags changes to core libraries ML: Samples Tags changes to samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AdaptiveCardInvokeResponseFactory.AdaptiveCard accepts wrong type Cannot set AdaptiveCardInvokeResponse Status via helper factory
2 participants
@tracyboehrer @MattB-msft