Updated Teams AI Lib to comply with project specs and create a proper… #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ML: Core
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Teams AI Library by enhancing code maintainability, extensibility, and null safety while simplifying schema management. Key changes include making state management methods virtual for override support, replacing hardcoded schema requirements with reusable static arrays, and updating method calls to include cancellation tokens and proper null handling.
Reviewed Changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Models/OpenAIModel.cs | Updated null-forgiving operators, cancellation token usage, and static modifier changes. |
| src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Models/ChatRole.cs and ChatMessage.cs | Adjusted method signatures and optimized collection access (Count property). |
| src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Augmentations/MonologueAugmentation.cs | Replaced inline schema requirements with static arrays and streamlined section construction. |
| src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Action/* | Applied nullability improvements, generic logger initialization, and updated attribute usage. |
| src/libraries/Builder/Microsoft.Agents.Builder/State/TurnState.cs | Marked key state methods as virtual to facilitate extensibility. |
src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Action/ActionHandler.cs
Show resolved
Hide resolved
...es/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Augmentations/MonologueAugmentation.cs
Show resolved
Hide resolved
src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Action/ActionCollection.cs
Show resolved
Hide resolved
Added CA1854 to the NoWarn property in the project file to suppress warnings related to this specific code analysis rule, in addition to the existing warnings.
This commit introduces new features and improvements by adding essential lines of code while removing outdated or unnecessary sections. The changes aim to optimize the program's behavior and maintainability.
tracyboehrer
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to enhance code maintainability, improve null safety, and simplify schema management. Key changes include making methods in
TurnStatevirtual for easier extensibility, replacing hardcoded schema requirements with reusable static fields, and addressing nullable reference types across multiple files.Enhancements to extensibility:
HasValue,SetValue, andDeleteValuemethods inTurnStatevirtual to allow overriding in derived classes (src/libraries/Builder/Microsoft.Agents.Builder/State/TurnState.cs). [1] [2]Improvements to schema management:
MonologueAugmentationand related classes (src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Augmentations/MonologueAugmentation.cs). [1] [2] [3] [4] [5]Null safety and type improvements:
ActionCollectionandActionHandlerto use nullable reference types, ensuring better handling of potential null values (src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Action/ActionCollection.cs,src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Action/ActionHandler.cs). [1] [2] [3] [4]!) in various scenarios to address nullable warnings and improve code clarity. [1] [2]Additional updates:
#pragmadirectives to suppress specific code analysis warnings, such as marking members as static and attributes withAttributeUsageAttribute(src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Action/DefaultActions.cs,src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Action/ActionParameterAttribute.cs). [1] [2]DefaultActionsby utilizing generic type parameters (src/libraries/Extensions/Microsoft.Agents.Extensions.Teams.AI/AI/Action/DefaultActions.cs).… nuget package.