Skip to content

Fix: TypingTimer was not stopping for streamingresponses #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025

Conversation

tracyboehrer
Copy link
Member

Fixes #318

@Copilot Copilot AI review requested due to automatic review settings June 4, 2025 16:44
@tracyboehrer tracyboehrer requested a review from a team as a code owner June 4, 2025 16:44
@tracyboehrer tracyboehrer enabled auto-merge June 4, 2025 16:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the TypingTimer was not stopping during streaming responses. Key changes include:

  • Updating the conditional check to handle activities of type Typing when a streaming entity is present.
  • Ensuring that the timer properly stops for streaming responses.
Comments suppressed due to low confidence (1)

src/libraries/Builder/Microsoft.Agents.Builder/App/TypingTimer.cs:146

  • Consider adding an inline comment to explain that checking 'activity.GetStreamingEntity() != null' supports stopping the timer for streaming responses.
if (activity.Type == ActivityTypes.Message || (activity.Type == ActivityTypes.Typing && activity.GetStreamingEntity() != null))

@github-actions github-actions bot added the ML: Core Tags changes to core libraries label Jun 4, 2025
@tracyboehrer tracyboehrer merged commit 8f1b755 into main Jun 12, 2025
8 checks passed
@tracyboehrer tracyboehrer deleted the users/tracyboehrer/typing-timer-stop branch June 12, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ML: Core Tags changes to core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShowTyping does not stop when StreamingResponse is used
2 participants