Handling non-JWT token during OAuth by not caching #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses issue #325 by ensuring non-JWT tokens are not cached incorrectly during OAuth. Key changes include distinguishing GitHub tokens by a "gho_" prefix, setting a short expiration for these tokens, and wrapping JWT processing in a try‐catch block to handle parsing failures.
src/libraries/Client/Microsoft.Agents.Connector/RestClients/UserTokenRestClient.cs
Outdated
Show resolved
Hide resolved
rido-min
reviewed
Jun 10, 2025
src/libraries/Client/Microsoft.Agents.Connector/RestClients/UserTokenRestClient.cs
Outdated
Show resolved
Hide resolved
…f sliding expiration
MattB-msft
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325