Skip to content

chore: migrate directlinespeech to tsup #5434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore: migrate directlinespeech to tsup #5434

wants to merge 4 commits into from

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Feb 25, 2025 •
edited
Loading

Fixes #5433

Changelog Entry

(no changelog entry for build change)

Description

Design

Specific Changes

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny force-pushed the fix/remove-ds-build-step branch from f194550 to 32e0bd9 Compare February 25, 2025 23:43
@OEvgeny OEvgeny changed the title Fix/remove ds build step chore: migrate directlinespeech to tsup Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n will be requested when the pull request is marked ready for review a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim will be requested when the pull request is marked ready for review compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten will be requested when the pull request is marked ready for review cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath will be requested when the pull request is marked ready for review srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford will be requested when the pull request is marked ready for review tdurnford is a code owner

@beyackle2 beyackle2 Awaiting requested review from beyackle2 beyackle2 will be requested when the pull request is marked ready for review beyackle2 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove esbuild from dependencies
1 participant
@OEvgeny